Make logpoint test more robust
Make the wait for and click link function look for only infor messages
in order to avoid it clicking on error messages instead.
Bug: 1027458
Change-Id: I7c856499877b329196aa5128ec20b5a0c844adc4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4241365
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Auto-Submit: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
diff --git a/test/e2e/console/console-log_test.ts b/test/e2e/console/console-log_test.ts
index 8c0caff..3f44faa 100644
--- a/test/e2e/console/console-log_test.ts
+++ b/test/e2e/console/console-log_test.ts
@@ -24,7 +24,7 @@
getStructuredConsoleMessages,
navigateToConsoleTab,
showVerboseMessages,
- waitForConsoleMessageAndClickOnLink,
+ waitForConsoleInfoMessageAndClickOnLink,
waitForLastConsoleMessageToHaveContent,
} from '../helpers/console-helpers.js';
import {
@@ -417,7 +417,7 @@
await target.evaluate('triggerLogpoint(42)');
await navigateToConsoleTab();
- await waitForConsoleMessageAndClickOnLink();
+ await waitForConsoleInfoMessageAndClickOnLink();
await waitFor('.sources-edit-breakpoint-dialog');
});
diff --git a/test/e2e/cross_tool_integration/workflow_test.ts b/test/e2e/cross_tool_integration/workflow_test.ts
index 3f7bcde..a004fb8 100644
--- a/test/e2e/cross_tool_integration/workflow_test.ts
+++ b/test/e2e/cross_tool_integration/workflow_test.ts
@@ -15,7 +15,7 @@
import {
navigateToConsoleTab,
navigateToIssuesPanelViaInfoBar,
- waitForConsoleMessageAndClickOnLink,
+ waitForConsoleInfoMessageAndClickOnLink,
} from '../helpers/console-helpers.js';
import {
clickOnContextMenuItemFromTab,
@@ -48,7 +48,7 @@
it('Console -> Sources', async () => {
await navigateToConsoleTab();
- await waitForConsoleMessageAndClickOnLink();
+ await waitForConsoleInfoMessageAndClickOnLink();
await waitFor('.panel[aria-label="sources"]');
});
diff --git a/test/e2e/helpers/console-helpers.ts b/test/e2e/helpers/console-helpers.ts
index 9a5b583..05ceabcd 100644
--- a/test/e2e/helpers/console-helpers.ts
+++ b/test/e2e/helpers/console-helpers.ts
@@ -284,8 +284,8 @@
await waitFor(CONSOLE_VIEW_SELECTOR);
}
-export async function waitForConsoleMessageAndClickOnLink() {
- const consoleMessage = await waitFor('div.console-group-messages span.source-code');
+export async function waitForConsoleInfoMessageAndClickOnLink() {
+ const consoleMessage = await waitFor('div.console-group-messages .console-info-level span.source-code');
await click('span.devtools-link', {root: consoleMessage});
}