[go: nahoru, domu]

[RPP] Add timings to legacy timings track in TimelineModel

This is currently done in the data provider when it should be done in
the same place where other tracks are built (TimelineModel). Because we
will tear the data provider appart in crbug.com/1416533, it would be
convenient to define what should be part of the new system and what
should be kept in the legacy system. This piece of code should be kept
unfortunately, so this moves it to a file that will remain untouched.

The reason we need to keep this is because the track's data is used
outside the flamechart, in the details pane. So we need to make sure it
is properly built. Once the timings track in the flame chart is migrated
to the new system, we will have two pieces of code that look like
duplicates in that they both add timings to timings track. The
difference is one is done for the flame chart and the other for
compatibility with other features. When this happens I'll add an
explanatory comment to the legacy code remarking the duplicate code.

Bug: 1416533
Change-Id: Ia898bfc402c7dfc3d91984917c3daaa29d3db4fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4307569
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
3 files changed
tree: 4675a2cc9e5e45ae463d4e1b46e6fe94f0e0b27f
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .git-blame-ignore-revs
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .mailmap
  22. .npmignore
  23. .npmrc
  24. .style.yapf
  25. .stylelintignore
  26. .stylelintrc.json
  27. AUTHORS
  28. BUILD.gn
  29. codereview.settings
  30. DEPS
  31. LICENSE
  32. OWNERS
  33. package-lock.json
  34. package.json
  35. PRESUBMIT.py
  36. README.md
  37. tsconfig.json
  38. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch