commit | e83586a78550ff47310aeacc77145542952cac59 | [log] [tgz] |
---|---|---|
author | Andrés Olivares <andoli@chromium.org> | Fri Mar 03 14:29:34 2023 |
committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 03 15:21:32 2023 |
tree | 4675a2cc9e5e45ae463d4e1b46e6fe94f0e0b27f | |
parent | 887def8a186841731b3aecac72b488dd3c8fdf7d [diff] |
[RPP] Add timings to legacy timings track in TimelineModel This is currently done in the data provider when it should be done in the same place where other tracks are built (TimelineModel). Because we will tear the data provider appart in crbug.com/1416533, it would be convenient to define what should be part of the new system and what should be kept in the legacy system. This piece of code should be kept unfortunately, so this moves it to a file that will remain untouched. The reason we need to keep this is because the track's data is used outside the flamechart, in the details pane. So we need to make sure it is properly built. Once the timings track in the flame chart is migrated to the new system, we will have two pieces of code that look like duplicates in that they both add timings to timings track. The difference is one is done for the flame chart and the other for compatibility with other features. When this happens I'll add an explanatory comment to the legacy code remarking the duplicate code. Bug: 1416533 Change-Id: Ia898bfc402c7dfc3d91984917c3daaa29d3db4fa Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4307569 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Andres Olivares <andoli@chromium.org>
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com.
Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466
) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
All open DevTools tickets on crbug.com
File a new DevTools ticket: new.crbug.com
Code reviews mailing list: devtools-reviews@chromium.org
@ChromeDevTools on Twitter
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools