[eslint] Enable rule that prevents exporting UIStrings objects
The CL was automatically generated by the rule itself as it includes
a fix to remove the export keyword.
R=jacktfranklin@chromium.org, petermarshall@chromium.org
Bug: chromium:1180760
Change-Id: I6571e1274e42a44cd01d98d08adb11b1ae68bf31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2720369
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
diff --git a/.eslintrc.js b/.eslintrc.js
index 762443b..e4b060d 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -140,7 +140,6 @@
// DevTools specific rules
'rulesdir/es_modules_import': 2,
'rulesdir/check_license_header': 2,
- 'rulesdir/l10n_filename_matches': 2,
},
'overrides': [{
'files': ['*.ts'],
diff --git a/front_end/.eslintrc.js b/front_end/.eslintrc.js
index 689eba2..0a6f356 100644
--- a/front_end/.eslintrc.js
+++ b/front_end/.eslintrc.js
@@ -7,6 +7,11 @@
rulesDirPlugin.RULES_DIR = path.join(__dirname, '..', 'scripts', 'eslint_rules', 'lib');
module.exports = {
+ 'rules': {
+ // L10n rules are only relevant in 'front_end'.
+ 'rulesdir/l10n_filename_matches': 2,
+ 'rulesdir/l10n_no_uistrings_export': 2,
+ },
'overrides': [
{
'files': ['*.ts'],
diff --git a/front_end/timeline_model/TimelineIRModel.ts b/front_end/timeline_model/TimelineIRModel.ts
index 90852c5..bb7c41e 100644
--- a/front_end/timeline_model/TimelineIRModel.ts
+++ b/front_end/timeline_model/TimelineIRModel.ts
@@ -8,7 +8,7 @@
import * as i18n from '../i18n/i18n.js';
import type * as SDK from '../sdk/sdk.js';
-export const UIStrings = {
+const UIStrings = {
/**
* @description Error text in Timeline IRModel of the Performance panel. Indicates that two fling
* gestures were detected at the same time, which should not be possible.
diff --git a/front_end/timeline_model/TimelineJSProfile.ts b/front_end/timeline_model/TimelineJSProfile.ts
index add75cb..4839fbf 100644
--- a/front_end/timeline_model/TimelineJSProfile.ts
+++ b/front_end/timeline_model/TimelineJSProfile.ts
@@ -10,7 +10,7 @@
import {RecordType, TimelineModelImpl} from './TimelineModel.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text for the name of a thread of the page
*@example {1} PH1
diff --git a/front_end/timeline_model/TimelineModel.ts b/front_end/timeline_model/TimelineModel.ts
index ac721c3..ac12651 100644
--- a/front_end/timeline_model/TimelineModel.ts
+++ b/front_end/timeline_model/TimelineModel.ts
@@ -40,7 +40,7 @@
import {TimelineJSProfileProcessor} from './TimelineJSProfile.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text for the name of a thread of the page
*@example {1} PH1
diff --git a/front_end/ui/DockController.js b/front_end/ui/DockController.js
index eaf0615..56db4c0 100644
--- a/front_end/ui/DockController.js
+++ b/front_end/ui/DockController.js
@@ -36,7 +36,7 @@
import {Context} from './Context.js'; // eslint-disable-line no-unused-vars
import {Provider, ToolbarButton, ToolbarItem} from './Toolbar.js'; // eslint-disable-line no-unused-vars
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text to close something
*/
diff --git a/front_end/ui/EmptyWidget.js b/front_end/ui/EmptyWidget.js
index c53be79..a0c9450 100644
--- a/front_end/ui/EmptyWidget.js
+++ b/front_end/ui/EmptyWidget.js
@@ -33,7 +33,7 @@
import {VBox} from './Widget.js';
import {XLink} from './XLink.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text that is usually a hyperlink to more documentation
*/
diff --git a/front_end/ui/FilterBar.js b/front_end/ui/FilterBar.js
index e7d3d73..c63b255 100644
--- a/front_end/ui/FilterBar.js
+++ b/front_end/ui/FilterBar.js
@@ -43,7 +43,7 @@
import {CheckboxLabel, createTextChild} from './UIUtils.js';
import {HBox} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text to filter result items
*/
diff --git a/front_end/ui/Infobar.js b/front_end/ui/Infobar.js
index 7adfbfa..c0055c4 100644
--- a/front_end/ui/Infobar.js
+++ b/front_end/ui/Infobar.js
@@ -11,7 +11,7 @@
import {createShadowRootWithCoreStyles} from './utils/create-shadow-root-with-core-styles.js';
import {Widget} from './Widget.js'; // eslint-disable-line no-unused-vars
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text on a button to close the infobar and never show the infobar in the future
*/
diff --git a/front_end/ui/InspectorView.js b/front_end/ui/InspectorView.js
index c6552fd..8bb6329 100644
--- a/front_end/ui/InspectorView.js
+++ b/front_end/ui/InspectorView.js
@@ -51,7 +51,7 @@
import {ViewManager} from './ViewManager.js';
import {VBox, WidgetFocusRestorer} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Title of more tabs button in inspector view
*/
diff --git a/front_end/ui/ListWidget.js b/front_end/ui/ListWidget.js
index 8625595..ab3ef2d 100644
--- a/front_end/ui/ListWidget.js
+++ b/front_end/ui/ListWidget.js
@@ -11,7 +11,7 @@
import {createInput, createTextButton, ElementFocusRestorer} from './UIUtils.js';
import {VBox} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text on a button to start editing text
*/
diff --git a/front_end/ui/RemoteDebuggingTerminatedScreen.js b/front_end/ui/RemoteDebuggingTerminatedScreen.js
index 050867e..ac52726 100644
--- a/front_end/ui/RemoteDebuggingTerminatedScreen.js
+++ b/front_end/ui/RemoteDebuggingTerminatedScreen.js
@@ -8,7 +8,7 @@
import {createTextButton, formatLocalized} from './UIUtils.js';
import {VBox} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text in a dialog box showing how to reconnect to DevTools when remote debugging has been terminated
*/
diff --git a/front_end/ui/SearchableView.js b/front_end/ui/SearchableView.js
index 4cd2007..94e07e9 100644
--- a/front_end/ui/SearchableView.js
+++ b/front_end/ui/SearchableView.js
@@ -40,7 +40,7 @@
import {createTextButton} from './UIUtils.js';
import {VBox} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text on a button to replace one instance with input text for the ctrl+F search bar
*/
diff --git a/front_end/ui/SettingsUI.js b/front_end/ui/SettingsUI.js
index 4089d9b..78371af 100644
--- a/front_end/ui/SettingsUI.js
+++ b/front_end/ui/SettingsUI.js
@@ -37,7 +37,7 @@
import {Tooltip} from './Tooltip.js';
import {CheckboxLabel} from './UIUtils.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Note when a setting change will require the user to reload DevTools
*@example {*} PH1
diff --git a/front_end/ui/SoftContextMenu.js b/front_end/ui/SoftContextMenu.js
index 2e8a051..3563a0d 100644
--- a/front_end/ui/SoftContextMenu.js
+++ b/front_end/ui/SoftContextMenu.js
@@ -37,7 +37,7 @@
import {Icon} from './Icon.js';
import {createTextChild, ElementFocusRestorer} from './UIUtils.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text exposed to screen readers on checked items.
*/
diff --git a/front_end/ui/SoftDropDown.js b/front_end/ui/SoftDropDown.js
index 5bd9991..be5601e 100644
--- a/front_end/ui/SoftDropDown.js
+++ b/front_end/ui/SoftDropDown.js
@@ -15,7 +15,7 @@
import {appendStyle} from './utils/append-style.js';
import {createShadowRootWithCoreStyles} from './utils/create-shadow-root-with-core-styles.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Placeholder text in Soft Drop Down
*/
diff --git a/front_end/ui/SplitWidget.js b/front_end/ui/SplitWidget.js
index 2e4b33e..47ba4bf 100644
--- a/front_end/ui/SplitWidget.js
+++ b/front_end/ui/SplitWidget.js
@@ -38,7 +38,7 @@
import {Widget} from './Widget.js';
import {Events as ZoomManagerEvents, ZoomManager} from './ZoomManager.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text to show a tool or panel
*@example {Audits} PH1
diff --git a/front_end/ui/SuggestBox.js b/front_end/ui/SuggestBox.js
index 3e8f3db..326d7c7 100644
--- a/front_end/ui/SuggestBox.js
+++ b/front_end/ui/SuggestBox.js
@@ -42,7 +42,7 @@
import {createShadowRootWithCoreStyles} from './utils/create-shadow-root-with-core-styles.js';
import {measuredScrollbarWidth} from './utils/measured-scrollbar-width.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Aria alert to read the suggestion for the suggestion box when typing in text editor
*@example {name} PH1
diff --git a/front_end/ui/TabbedPane.js b/front_end/ui/TabbedPane.js
index 1a0b8a6..4f03e85 100644
--- a/front_end/ui/TabbedPane.js
+++ b/front_end/ui/TabbedPane.js
@@ -42,7 +42,7 @@
import {VBox, Widget} from './Widget.js'; // eslint-disable-line no-unused-vars
import {Events as ZoomManagerEvents, ZoomManager} from './ZoomManager.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description The aria label for the button to open more tabs at the right tabbed pane in Elements tools
*/
diff --git a/front_end/ui/TargetCrashedScreen.js b/front_end/ui/TargetCrashedScreen.js
index 13f3179..fc7dec0 100644
--- a/front_end/ui/TargetCrashedScreen.js
+++ b/front_end/ui/TargetCrashedScreen.js
@@ -6,7 +6,7 @@
import {VBox} from './Widget.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text in dialog box when the target page crashed
*/
diff --git a/front_end/ui/UIUtils.js b/front_end/ui/UIUtils.js
index 66dc739..09f19fb 100644
--- a/front_end/ui/UIUtils.js
+++ b/front_end/ui/UIUtils.js
@@ -52,7 +52,7 @@
import {measuredScrollbarWidth} from './utils/measured-scrollbar-width.js';
import {registerCustomElement} from './utils/register-custom-element.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Micros format in UIUtils
*@example {2} PH1
diff --git a/front_end/ui/ViewManager.js b/front_end/ui/ViewManager.js
index 8604160..64a479c 100644
--- a/front_end/ui/ViewManager.js
+++ b/front_end/ui/ViewManager.js
@@ -16,7 +16,7 @@
import {getRegisteredLocationResolvers, getRegisteredViewExtensions, registerLocationResolver, registerViewExtension, ViewLocationCategoryValues, ViewLocationValues, ViewPersistence, ViewRegistration} from './ViewRegistration.js';
import {VBox, Widget} from './Widget.js'; // eslint-disable-line no-unused-vars
-export const UIStrings = {
+const UIStrings = {
/**
*@description Aria label for the tab panel view container
*@example {Sensors} PH1
diff --git a/front_end/ui/components/DataGrid.ts b/front_end/ui/components/DataGrid.ts
index 8e697cc..54f993d 100644
--- a/front_end/ui/components/DataGrid.ts
+++ b/front_end/ui/components/DataGrid.ts
@@ -16,7 +16,7 @@
import {calculateColumnWidthPercentageFromWeighting, calculateFirstFocusableCell, Cell, CellPosition, Column, ContextMenuHeaderResetClickEvent, getRowEntryForColumnId, handleArrowKeyNavigation, renderCellValue, Row, SortDirection, SortState} from './DataGridUtils.js';
import * as i18n from '../../i18n/i18n.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description A context menu item in the Data Grid of a data grid
*/
diff --git a/front_end/ui/components/SurveyLink.ts b/front_end/ui/components/SurveyLink.ts
index c68d746..85dc48d 100644
--- a/front_end/ui/components/SurveyLink.ts
+++ b/front_end/ui/components/SurveyLink.ts
@@ -9,7 +9,7 @@
import type {IconData} from './Icon.js';
import * as i18n from '../../i18n/i18n.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text shown when the link to open a survey is clicked but the survey has not yet appeared
*/
diff --git a/front_end/web_audio/AudioContextContentBuilder.ts b/front_end/web_audio/AudioContextContentBuilder.ts
index 4a806ff..261e006 100644
--- a/front_end/web_audio/AudioContextContentBuilder.ts
+++ b/front_end/web_audio/AudioContextContentBuilder.ts
@@ -6,7 +6,7 @@
import * as i18n from '../i18n/i18n.js';
import * as UI from '../ui/ui.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text in Audio Context Content Builder
*/
diff --git a/front_end/web_audio/AudioContextSelector.ts b/front_end/web_audio/AudioContextSelector.ts
index f2010cc..ae76dea 100644
--- a/front_end/web_audio/AudioContextSelector.ts
+++ b/front_end/web_audio/AudioContextSelector.ts
@@ -8,7 +8,7 @@
import * as Platform from '../platform/platform.js';
import * as UI from '../ui/ui.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text that shows there is no recording
*/
diff --git a/front_end/web_audio/WebAudioView.ts b/front_end/web_audio/WebAudioView.ts
index 0b85090..ed6564f 100644
--- a/front_end/web_audio/WebAudioView.ts
+++ b/front_end/web_audio/WebAudioView.ts
@@ -13,7 +13,7 @@
import {GraphManager} from './graph_visualizer/GraphManager.js';
import {Events as ModelEvents, WebAudioModel} from './WebAudioModel.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text in Web Audio View
*/
diff --git a/front_end/web_audio/web_audio-meta.ts b/front_end/web_audio/web_audio-meta.ts
index c904002..f46c3ad 100644
--- a/front_end/web_audio/web_audio-meta.ts
+++ b/front_end/web_audio/web_audio-meta.ts
@@ -9,7 +9,7 @@
// eslint-disable-next-line rulesdir/es_modules_import
import type * as WebAudio from './web_audio.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Title of the WebAudio tool
*/
diff --git a/front_end/webauthn/WebauthnPane.ts b/front_end/webauthn/WebauthnPane.ts
index 5bed7b6..ce71ad6 100644
--- a/front_end/webauthn/WebauthnPane.ts
+++ b/front_end/webauthn/WebauthnPane.ts
@@ -10,7 +10,7 @@
import * as SDK from '../sdk/sdk.js';
import * as UI from '../ui/ui.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Label for button that allows user to download the private key related to a credential.
*/
diff --git a/front_end/webauthn/webauthn-meta.ts b/front_end/webauthn/webauthn-meta.ts
index 952a78a..3c68ad4 100644
--- a/front_end/webauthn/webauthn-meta.ts
+++ b/front_end/webauthn/webauthn-meta.ts
@@ -9,7 +9,7 @@
// eslint-disable-next-line rulesdir/es_modules_import
import type * as Webauthn from './webauthn.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Title of WebAuthn tab in bottom drawer.
*/
diff --git a/front_end/workspace/UISourceCode.ts b/front_end/workspace/UISourceCode.ts
index ce84d05..8df0de0 100644
--- a/front_end/workspace/UISourceCode.ts
+++ b/front_end/workspace/UISourceCode.ts
@@ -39,7 +39,7 @@
import type {Project} from './WorkspaceImpl.js';
import {Events as WorkspaceImplEvents, projectTypes} from './WorkspaceImpl.js';
-export const UIStrings = {
+const UIStrings = {
/**
*@description Text for the index of something
*/