commit | 439ffaa451753eea8373122b3ceeb45cbeb49830 | [log] [tgz] |
---|---|---|
author | Fumitoshi Ukai <ukai@google.com> | Fri Jul 05 05:36:00 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 05 05:36:00 2024 |
tree | a72e11bc485812d4e01f9c96409cdc73c83a2957 | |
parent | 8bee07f5b51427ff2536b94cb6f2d9956a63fbe8 [diff] |
siso: ninja addEdge not refer state bindings. addEdge uses s.bindings for env, but env is updated for local env. pass local env to addEdge and not refer s.bindings. Change-Id: Ic041830f6363aaca92addf42e98010e698770912 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5679684 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Richard Wang <richardwa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Richard Wang <richardwa@google.com> Cr-Commit-Position: refs/heads/main@{#66654}
Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.