Issue 14099010: Move Version to base namespace.

Issue 14099010: Move Version to base namespace. (Closed)

Created:
7 years, 8 months ago by xhwang

Modified:
7 years, 8 months ago

Reviewers:
brettw, tommi (sloooow) - chröme

CC:
chromium-reviews, grt+watch_chromium.org, amit, Aaron Boodman, robertshield, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move Version to base namespace. Adds "using base::Version" to the header to avoid having to update everything at once. All forward declares and the locations where the forward declares are used are updated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195456

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -73 lines)			Patch
M	base/version.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	base/version.cc	View	1	4 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/component_updater/flash_component_installer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_api.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/external_provider_impl.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/external_provider_interface.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/pending_extension_manager.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_downloader.h	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/setup/install_worker.h	View		11 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/installer/setup/setup_util.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/test/alternate_version_generator.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/installer/util/install_util.h	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/installer/util/installation_state.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/installer/util/installer_state.h	View		4 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome_frame/dll_redirector.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_utils.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

xhwang

tommi: chrome_frame/dll_redirector.h brettw: everything else PTAL

7 years, 8 months ago (2013-04-19 23:05:29 UTC) #1

brettw

LGTM, thanks! https://codereview.chromium.org/14099010/diff/1/base/version.cc File base/version.cc (right): https://codereview.chromium.org/14099010/diff/1/base/version.cc#newcode78 base/version.cc:78: namespace base { I usually just wrap ...

7 years, 8 months ago (2013-04-20 04:15:10 UTC) #2

xhwang

https://codereview.chromium.org/14099010/diff/1/base/version.cc File base/version.cc (right): https://codereview.chromium.org/14099010/diff/1/base/version.cc#newcode78 base/version.cc:78: namespace base { On 2013/04/20 04:15:10, brettw wrote: > ...

7 years, 8 months ago (2013-04-20 05:53:44 UTC) #3