[go: nahoru, domu]

Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 21949007: Remove operator== from SkPaint (Closed)

Created:
7 years, 4 months ago by sglez
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove operator== from SkPaint Committed: http://code.google.com/p/skia/source/detail?r=10603

Patch Set 1 #

Total comments: 1

Patch Set 2 : Less verbose friend function #

Patch Set 3 : Fix lines breaking test. #

Total comments: 1

Patch Set 4 : Static function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M include/core/SkPaint.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/views/animated/SkStaticTextView.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M tests/PaintTest.cpp View 1 2 3 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sglez
7 years, 4 months ago (2013-08-05 18:14:30 UTC) #1
mtklein
looks good in spirit. just one nit on the implementation. https://codereview.chromium.org/21949007/diff/1/tests/PaintTest.cpp File tests/PaintTest.cpp (right): https://codereview.chromium.org/21949007/diff/1/tests/PaintTest.cpp#newcode139 ...
7 years, 4 months ago (2013-08-05 18:18:14 UTC) #2
mtklein
looks good in spirit. just one nit on the implementation.
7 years, 4 months ago (2013-08-05 18:18:15 UTC) #3
sglez
Changed from friend class to friend function.
7 years, 4 months ago (2013-08-05 18:58:27 UTC) #4
mtklein
On 2013/08/05 18:58:27, sglez wrote: > Changed from friend class to friend function. lgtm
7 years, 4 months ago (2013-08-05 19:34:38 UTC) #5
reed1
change is good, except I think we can simplify the unittest to not require special ...
7 years, 4 months ago (2013-08-05 20:40:36 UTC) #6
sglez
Small static function that only does what the test needs.
7 years, 4 months ago (2013-08-05 23:38:00 UTC) #7
reed1
if the tests still pass, lgtm
7 years, 4 months ago (2013-08-06 17:37:22 UTC) #8
mtklein
On 2013/08/06 17:37:22, reed1 wrote: > if the tests still pass, lgtm me too lgtm
7 years, 4 months ago (2013-08-06 18:21:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sglez@google.com/21949007/21001
7 years, 4 months ago (2013-08-07 14:15:45 UTC) #10
commit-bot: I haz the power
Change committed as 10603
7 years, 4 months ago (2013-08-07 15:22:08 UTC) #11
robertphillips
7 years, 4 months ago (2013-08-07 22:37:34 UTC) #12
Message was sent while issue was closed.
This was reverted in r10632 due to Chromium failures (e.g.,
http://108.170.217.252:10117/builders/Canary-Chrome-Ubuntu12-Ninja-x86_64-Def...)

Powered by Google App Engine
This is Rietveld 408576698