[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenMP directives #453

Open
EricEngle-NOAA opened this issue Oct 22, 2023 · 4 comments
Open

Add OpenMP directives #453

EricEngle-NOAA opened this issue Oct 22, 2023 · 4 comments
Assignees
@EricEngle-NOAA
Labels
enhancement New feature or request

Comments

@EricEngle-NOAA
Copy link
Contributor

There are several places where OpenMP directives can be added for faster performance -- mainly in the packing and unpacking functions were data are scaled (unscaled) and packed (unpacked).

Introducing this would also mean changes to the CMake configuration files so the OpenMP library can be linked.
@edwardhartnett edwardhartnett added the enhancement New feature or request label Oct 23, 2023
@EricEngle-NOAA EricEngle-NOAA mentioned this issue Oct 24, 2023
Closed
@edwardhartnett
Copy link
Contributor

@EricEngle-NOAA is this still a work in progress? What went wrong with your PR?

@edwardhartnett
Copy link
Contributor

Any progress on this? SHould I bump to next release?

@EricEngle-NOAA
Copy link
Contributor Author

No progress. Please table for the next release.

@edwardhartnett
Copy link
Contributor

We are now working more closely with the wgrib2 project, which (I think) has openmp everywhere. So it might be worth comparing codes. We can ask @webisu for lessons learned, or, even better, just cut and paste his already-working code! ;-)

I have bumped this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricEngle-NOAA EricEngle-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardhartnett @EricEngle-NOAA