[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threading does not obey limits #169

Open
rbutleriii opened this issue Jul 5, 2019 · 3 comments
Open

threading does not obey limits #169

rbutleriii opened this issue Jul 5, 2019 · 3 comments

Comments

@rbutleriii
Copy link

I have been running with the default threads and explicitly setting --thread 2 and in both cases, I see about 250-400% cpu usage. For parallelization that is an issue, as it appears the workers have access to more than one thread each.
@sfchen
Copy link
Member
sfchen commented Jul 6, 2019

--thread 2 means use 2 processing worker threads.

Besides the worker threads, fastp uses one master thread, one loader thread, and one or two writer thread (depends on SE or PE)

@rbutleriii
Copy link
Author

Fair enough. A feature request from me then would be to include that info in the documentation or in the --thread switch description. Conventional use of a thread switch usually defines the max threads it will consume for parallelization purposes.

@sfchen
Copy link
Member
sfchen commented Jul 6, 2019

Thanks, I will mention this in the doc

This was referenced Aug 25, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbutleriii @sfchen