[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remake Digital Universe grids with grid class #1683

Closed
micahnyc opened this issue Jul 15, 2021 · 1 comment · Fixed by #2216
Closed

Remake Digital Universe grids with grid class #1683

micahnyc opened this issue Jul 15, 2021 · 1 comment · Fixed by #2216
Labels
Component: Content Relating to the content shown in OpenSpace Type: Maintenance Changing the functionality of features without affecting its observable behavior

Comments

@micahnyc
Copy link
Contributor

The grids from digital universe are made with the RenderableDUMesh class. Since we now have a RenderableGrid class, they should be remade with that for consistency.
@micahnyc micahnyc added Component: Assets Type: Maintenance Changing the functionality of features without affecting its observable behavior Component: Content Relating to the content shown in OpenSpace labels Jul 15, 2021
@WeirdRubberDuck
Copy link
Contributor

Related issue: #1244, but actually, I guess the labels could be implemented just using a RenderableBillboardsCloud, similarly to the Spherical DU grids.

If we want to bake in the labels with the renderables, maybe we can make a subclass of the RenderableGrid and RenderableSphericalGrid that includes the labels. If we don't, then we should just close issue #1244

@alexanderbock alexanderbock changed the title Remake DU grids with grid class Remake Digital Universe grids with grid class May 21, 2022
@Roxeena Roxeena mentioned this issue Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Content Relating to the content shown in OpenSpace Type: Maintenance Changing the functionality of features without affecting its observable behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable highlights in grids OpenSpace/OpenSpace
3 participants
@micahnyc @alexanderbock @WeirdRubberDuck