-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endless install loop? #8
Comments
Also - if I modify electron-release-server to return only newer editions, the app throws an error (could not parse empty release file). |
@tkambler thanks for using the app. I'm sure there are still bugs to work out here and there. Your help in identifying them is much appreciated. Before we start, I'd like to make sure that you're publishing your app with the save version name as the one in your |
When you say "publishing" - what are you referring to? Certainly not My project structure looks like this:
It's built with I sign into the release server, click "Add a New Version," enter |
@tkambler Version 0.2.0 contains numerous fixes, one of which relates to the |
Windows works beautifully now - thanks! Unfortunately - OS X is now broken, which was working fine for me before.
FYI... In my previous attempts at using this (during which time, OS X seemed to be working fine), I was uploading the .dmg file and not the .zip. This time, however, I am uploading the .zip and not the .dmg, because the server (for good reason? I don't know?) filters out any non-zip assets in the controller. I'm about to strip that part out and serve up dmgs again and will see what happens. |
Serving up DMGs was a failure, going back to ZIPs. Possibly important: after the download of the updated ZIP has occurred, Also - if I manually download the updated .zip from the server, unpack it, and run the resulting .app myself - it is obviously the newer version that I want. |
This may be unrelated to the release server - I'm having the same problem seen here. |
Hi @tkambler, thanks for testing this. I'm glad to hear that Windows support has been repaired. DMGs should only be provided to the user for initial installation, that is why the release server filters out non-zip files for the update process. I'll look into this myself and see what I come up with. |
Things seem to be working now. The issue was with improper permissions set on Squirrel log files contained within |
Excellent, glad to hear. Let me know if you have any other issues or suggestions. |
@ArekSredzki - Frustratingly, I am again actually dealing with this issue. Question - In the VersionController - why does the OS X endpoint query for versions |
@tkambler On OS X the server is supposed to return any new releases that are available. That said, on Windows, because it uses a hash, you can return the current version as well. By using the hash, it can ensure that it is on that same version. Would you mind elaborating on the issue that you are having? |
I'm seeing an endless loop of upgrade installs. See original description from two days ago. And I have some more clues. I'm creating a 32-bit version of the app - that's the only one I'm uploading to the release server. I'm installing the app on a 64-bit machine. I'm doing some debugging on the local machine - particularly the process by which the update info is fetched. Crucially - when the update has been downloaded, I'm comparing the local version as reported by my app with the version of what was just downloaded. They do not match, based on a disparity b/w architectures. The local app reports its version as |
|
Windows. There is no such thing as a 32-bit OS X Electron app. Am about to go back to creating both 32 and 64 bit versions. Will report back. I don't think this should be necessary though... |
Of course, I wasn't thinking. I think that this will be resolved by using strict platform matching when resolving That way the 64 bit version will not see the update if one does not exist for that arch. We wouldn't want 64 bit versions "downgrading" themselves to 32bit anyway. I'll push an update after lunch. |
Deploying both 32 bit and 64 bit versions of the application seems to solve the issue. I'll do that for now. It would be nice though if this problem could be solved. It's not always necessary to deploy both... sometimes 32 bit is sufficient. |
@ArekSredzki Endless install loop bug is back with this update (0.3.0). |
http://bitcubby.com/files/skitch/Vagrant_-_Windows_10_1CCA6840.png I'm at version 1.0.0 of the app (the only version, which I have also uploaded to the release server). When the app launches, it fetches the list of available updates from the release server. Note the difference between the version that is reported by the release server and the version that the app sees itself as having (1.0.0 vs 1.0.0-ia32). |
@ArekSredzki I have a CI server that generates these builds for me. For the 32 bit build, the generated file looks like this:
For the 64 bit build, the generated file looks like this:
This problem seems to go away so long as I strip the |
Ugh, no - that doesn't fix it. I'm falling back to dual builds (32 / 64). |
@ArekSredzki If you don't have a good environment in which to replicate this, look me up on Freenode - channel #electron-release-server and we can step through this together. |
@tkambler I'll hit you up on there, but this is a usage issue. If the install is x64 then it should ask for win64 not win32 |
@tkambler I don't see you in that room. |
Skype? tkambler Try IRC again. Should work now. |
As far as I can tell, I'm following your instructions to the letter. After initially installing my app on Windows, my instance of electron-release-server is pinged for updates. The server returns an array containing a single entry: the current version - which I've just installed. The app then proceeds to download this and install it - again, again, and again.
The text was updated successfully, but these errors were encountered: