[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger loading transition if asset already loaded in memory #61

Closed
weotch opened this issue Feb 21, 2022 · 1 comment
Closed

Comments

@weotch
Copy link
Member
weotch commented Feb 21, 2022

Running into this when using visual instances in vue-ssr-carousel, see BKWLD/vue-ssr-carousel#10

@weotch
Copy link
Member Author
weotch commented Feb 21, 2022

This issue ended up being related to how I have a :key on the picture and video elements. I noticed that Vue is doing some surprising stuff related to reusing component instances when I re-order the slides as part of the looping feature in vue-ssr-carousel.

Specifically, when re-arranging slides, the same Vue Visual instance was used but a different image prop value was passed in. This change was triggering the key and the parent transition. Removing the key made everything feel right again.

In the future, if a component wants to swap the image, the visual instance as a whole should be keyed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant