[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit code is 0 on error #367

Closed
2 tasks done
username-is-already-taken2 opened this issue May 11, 2023 · 1 comment
Closed
2 tasks done

exit code is 0 on error #367

username-is-already-taken2 opened this issue May 11, 2023 · 1 comment
Labels
bug: needs reproduction

Comments

@username-is-already-taken2
Copy link
  • I have tried upgrading by running bundle update vite_ruby.
  • I have read the troubleshooting section before opening an issue.

Description 📖

Some of my assets aren't compiling (due to my code :) but after the error the exit code was still 0 so my docker build still carried on.

Just to confirm without my typo normally my assets compile fine what I'm trying to cover off with this issue is catching the error next time,

Reproduction 🐞

ran bundle exec rails vite:build

image

Vite Ruby Info

Run bin/rake vite:info and provide the output:

image

Logs 📜

If not providing a reproduction:

Output

Run DEBUG=vite-plugin-ruby:* bin/vite dev or DEBUG=vite-plugin-ruby:* bin/vite build and provide the output:

image
@username-is-already-taken2 username-is-already-taken2 added the bug: pending triage Something doesn't seem to be working, but hasn't been verified label May 11, 2023
@ElMassimo ElMassimo added bug: needs reproduction and removed bug: pending triage Something doesn't seem to be working, but hasn't been verified labels May 11, 2023
@ElMassimo
Copy link
Owner
ElMassimo commented May 11, 2023 •
edited
Loading

Hi Gary!

Looking at the logs, it seems that the Vite build succeeded, so it's likely that this particular error was a type error (not a build-failing error).

I'd suggest running type-checking in a way that causes the CI to fail (not familiar with vite-dts, perhaps it should be modified to cause Vite to fail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: needs reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElMassimo @username-is-already-taken2