[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with dry-cli 0.7 #76

Closed
adenta opened this issue May 9, 2021 · 2 comments
Closed

issue with dry-cli 0.7 #76

adenta opened this issue May 9, 2021 · 2 comments
Labels
bug: pending triage Something doesn't seem to be working, but hasn't been verified

Comments

@adenta
Copy link
adenta commented May 9, 2021

Last week I did a clean install of the vite_rails gem.

Just tried to do one now, and it didn't work.

This was resolved by going into my Gemfile.lock and downgrading dry-cli to version 0.6.
@adenta adenta added the bug: pending triage Something doesn't seem to be working, but hasn't been verified label May 9, 2021
@braidn
Copy link
braidn commented May 9, 2021

Confirmed! I have the same issue. Stacktrace using Ruby 2.7.1 and Dry CLI 0.7:

bundler: failed to load command: vite (/Users/braidn/src/play/ruby/ror6-explore/.bundle/ruby/2.7.0/bin/vite)
LoadError: cannot load such file -- dry/cli/utils/files
.bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:34:in `require'
.bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:34:in `require'
.bundle/ruby/2.7.0/gems/vite_ruby-1.2.9/lib/vite_ruby/cli/install.rb:3:in `<top (required)>'
  .bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:26:in `require'
  .bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:26:in `require'
  .bundle/ruby/2.7.0/gems/vite_ruby-1.2.9/lib/vite_ruby/cli.rb:13:in `<class:CLI>'
 .bundle/ruby/2.7.0/gems/vite_ruby-1.2.9/lib/vite_ruby/cli.rb:7:in `<top (required)>'
.bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:26:in `require'
 .bundle/ruby/2.7.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:26:in `require'
  .bundle/ruby/2.7.0/gems/vite_ruby-1.2.9/exe/vite:9:in `<top (required)>'
 .bundle/ruby/2.7.0/bin/vite:23:in `load'
 .bundle/ruby/2.7.0/bin/vite:23:in `<top (required)>'

@ElMassimo
Copy link
Owner
ElMassimo commented May 9, 2021 •
edited
Loading

Thanks for reporting!

It's unfortunate that dry-cli released a new version with this breaking change.

The missing dry/cli/utils/files file seems to have been extracted to a new gem, dry-files.

As a short term measure, I've released vite_ruby@1.2.10, which is more strict with the version of dry-cli.

For the next steps, I think it's reasonable to avoid an extra dependency and instead bundle the code for the few file operations that are needed during installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: pending triage Something doesn't seem to be working, but hasn't been verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@braidn @ElMassimo @adenta