[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets not minifying for production #91

Closed
1 task done
damwhit opened this issue Jun 10, 2021 · 2 comments
Closed
1 task done

Assets not minifying for production #91

damwhit opened this issue Jun 10, 2021 · 2 comments
Labels
question Further information is requested

Comments

@damwhit
Copy link
damwhit commented Jun 10, 2021 •
edited
Loading

Description 馃摉

First off, thanks for putting this project together. It's such an improvement on webpacker regarding its ease of use and configuration.

I'm deploying a dockerized rails app to heroku and followed the instructions in the docs site for a heroku deploy. I also confirmed that the vite:build command is running when the assets:precompile command runs.

I feel like there is something simple that I'm missing, but when I look at the source code for my deployed app, all of the js not minified and the tree structure is in tact (screenshot comparison below between the sample deployed app on the docs site and my deployed app).

Reproduction 馃悶

https://github.com/damwhit/harvest_helper/tree/vite-vue

Screenshots 馃摲

Screen Shot 2021-06-10 at 2 26 08 PM

Screen Shot 2021-06-10 at 2 26 00 PM

Thanks for your help!
@damwhit damwhit added the bug: pending triage Something doesn't seem to be working, but hasn't been verified label Jun 10, 2021
@ElMassimo ElMassimo added question Further information is requested and removed bug: pending triage Something doesn't seem to be working, but hasn't been verified labels Jun 10, 2021
@ElMassimo
Copy link
Owner
ElMassimo commented Jun 10, 2021 •
edited
Loading

Hi David!

The .vue component that you are seeing is being obtained by the browser through the sourcemaps, since you are inspecting the app in DevTools.

HarvestHelper

If you click the (source mapped from ...) link, it will open the JS file being used on the page, and if you pretty-print the file you should be able to find your compiled Vue components:

HarvestHelper

The sourcemaps are only fetched if you open DevTools, so don't worry about performance. They are very helpful because you can set breakpoints on the original sources, as well as get the exact line where an error occurred if you are using a bug tracker.

@damwhit
Copy link
Author
damwhit commented Jun 10, 2021

I figured that it was something simple. Thanks so much for the quick reply and glad to hear that it's working as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElMassimo @damwhit