pay: Pre-flight checks and better error messages #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e4610d
to
bc7e939
Compare
rustyrussell
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Ack 834997c
Nits: needs folding in the fixup and removing "connected" parsing....
| err = json_scan(tmpctx, buf, channel, | ||
| "{spendable_msat?:%,peer_connected:%}", | ||
| JSON_SCAN(json_to_msat, &spendable), | ||
| JSON_SCAN(json_to_bool, &connected)); |
There was a problem hiding this comment.
Why do you grab "connected" and not use it?
This allows us to directly returnan error code based on where we decided to abort, rather than attemtping to infer it from the parts. Changelog-Added: pay: The pay plugin now returns better error codes
Changelog-Added: pay: The pay plugin now checks whether we have enough spendable capacity before computing a route, returning a clear error message if we don't
834997c
to
c1eee7c
Compare
Should make debugging based on logs a bit simpler.
Changelog-Changed: pay: Improved logging should facilitate debugging considerably.
c1eee7c
to
2d50a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have long had an issue with the "Ran out of routes" error
essentially covering up the real reason a payment has failed. Let's
try and add some better error messages as well as do some additional
checks that can tell us what went wrong in the first place.