[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mobile device preset to match newer devices #14256

Closed
connorjclark opened this issue Aug 2, 2022 · 8 comments
Closed

Update mobile device preset to match newer devices #14256

connorjclark opened this issue Aug 2, 2022 · 8 comments
Assignees
@connorjclark
Labels
P1

Comments

@connorjclark
Copy link
Collaborator
connorjclark commented Aug 2, 2022 •
edited by paulirish
Loading

https://twitter.com/patrickhulce/status/1554163245937737730

viewport, DPR, UA (but not CPU multiplier)

see also: #10741 (comment) about DPR. tldr: while lighthouse made some bad calls if our reference device was dpr=3, we (conceivably) fixed that so that shouldn't be a problem anymore.
@patrickhulce
Copy link
Collaborator

Heh, I was going to file with some supporting evidence if you were lukewarm positive, thank you! :)

@benschwarz
Copy link
Contributor

Motorola Moto G Power is a great candidate

@adamraine
Copy link
Member

Can this be merged into #12235?

@connorjclark
Copy link
Collaborator Author

I feel like our more recent plans have taken precedence over that. @paulirish is that right? Anything from that issue/its doc that you feel we should do / conflicts with our present path of using Motorola Moto G Power?

@paulirish paulirish changed the title Update mobile preset to match newer devices Update mobile device preset to match newer devices Oct 21, 2022
@connorjclark
Copy link
Collaborator Author

#12235 is just network, this is viewport/device, so different issues.

@adamraine adamraine mentioned this issue Nov 10, 2022
Closed
@connorjclark
Copy link
Collaborator Author

Moto G Power (2022) 1600x720

amazon store page

window.innerWidth: 412
window.innerHeight: 767
screen.width: 412
screen.height: 915
DPR: 1.75
UA: Mozilla/5.0 (Linux; Android 11; moto g power (2022)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.85 Mobile Safari/537.36

@connorjclark connorjclark mentioned this issue Jan 13, 2023
Merged
@connorjclark
Copy link
Collaborator Author

#14674 for core, also need to do CDT.

@connorjclark connorjclark removed the 10.0 label Feb 6, 2023
@connorjclark
Copy link
Collaborator Author

There's still #14743 , but this is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connorjclark connorjclark

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@benschwarz @paulirish @patrickhulce @connorjclark @adamraine @devtools-bot