tests(font-size): add test for attributing styles to node #9400
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,10 @@ | |
| const FontSizeAudit = require('../../../audits/seo/font-size.js'); | ||
| const assert = require('assert'); | ||
|
|
||
| const URL = { | ||
| requestedUrl: 'https://example.com', | ||
| finalUrl: 'https://example.com', | ||
| }; | ||
| const validViewport = 'width=device-width'; | ||
|
|
||
| /* eslint-env jest */ | ||
|
|
@@ -234,4 +237,54 @@ describe('SEO: Font size audit', () => { | |
| expect(auditResult.score).toBe(1); | ||
| expect(auditResult.notApplicable).toBe(true); | ||
| }); | ||
|
|
||
| describe('attributes source location', () => { | ||
| function runFontSizeAuditWithSingleFailingStyle(style, nodeProperties) { | ||
| const artifacts = { | ||
| URL: {finalUrl: 'http://www.example.com'}, | ||
| MetaElements: makeMetaElements(validViewport), | ||
| FontSize: { | ||
| analyzedFailingNodesData: [ | ||
| {textLength: 1, fontSize: 1, node: {nodeId: 1, ...nodeProperties}, cssRule: style}, | ||
| ], | ||
| }, | ||
| TestedAsMobileDevice: true, | ||
| }; | ||
| return FontSizeAudit.audit(artifacts, getFakeContext()); | ||
| } | ||
|
|
||
| it('to inline node stylesheet', async () => { | ||
| const auditResult = await runFontSizeAuditWithSingleFailingStyle({ | ||
| type: 'Inline', | ||
| }, { | ||
| parentNode: {attributes: ['id', 'my-parent']}, | ||
| localName: 'p', | ||
| attributes: ['class', 'my-p'], | ||
| }); | ||
|
|
||
|
There was a problem hiding this comment. Oh my gosh wait yeah this file is completely different! I'm sorry @connorjclark I got confused between two different font-size-test changes and approved this immediately after looking at the other one, too many reviews today my b 😢 There was a problem hiding this comment. is there a separate review ongoing with There was a problem hiding this comment. you even tried to warn me over chat and it didn't work! 😆 There was a problem hiding this comment. nope, this was it. There was a problem hiding this comment.
there was one in #9354, though? #9400 (comment) There was a problem hiding this comment. yes... and I moved it here and asked patrick to review over chat :) a flawless system as you see |
||
| assert.equal(auditResult.details.items.length, 1); | ||
connorjclark marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expect(auditResult.details.items[0].selector).toMatchObject({ | ||
| type: 'node', | ||
| selector: '#my-parent', | ||
| snippet: '<p class="my-p">', | ||
| }); | ||
| }); | ||
|
|
||
| it('to attributes node stylesheet', async () => { | ||
| const auditResult = await runFontSizeAuditWithSingleFailingStyle({ | ||
| type: 'Attributes', | ||
| }, { | ||
| parentNode: {attributes: ['id', 'my-parent']}, | ||
| localName: 'font', | ||
| attributes: ['size', '10px'], | ||
| }); | ||
|
|
||
| assert.equal(auditResult.details.items.length, 1); | ||
| expect(auditResult.details.items[0].selector).toMatchObject({ | ||
| type: 'node', | ||
| selector: '#my-parent', | ||
| snippet: '<font size="10px">', | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also not a valid
URLartifact :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to make artifacts in tests fully complete, or just the parts we need for the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessarily, I just found it funny :)
(
URLis declared at the top level, though, so could be reused likevalidViewportis)