[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid default if script.start doesn't exist #375

Closed
steren opened this issue Jan 13, 2024 · 1 comment
Closed

Invalid default if script.start doesn't exist #375

steren opened this issue Jan 13, 2024 · 1 comment
Labels
kind/bug Something isn't working

Comments

@steren
Copy link
Contributor
steren commented Jan 13, 2024

I can read: If scripts.start is not set, the buildpack will run npm start.

This is an incorrect default behavior: If scripts.start is not set, npm start will always fail with Missing script: "start"

I'd expect instead to default to node index.js

CC @jama22
@steren steren added the kind/bug Something isn't working label Jan 13, 2024
@matthewrobertson
Copy link
Member

This is a reasonable default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steren @matthewrobertson