[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java version defaults to version 11 #385

Open
mstahv opened this issue Feb 14, 2024 · 4 comments
Open

Java version defaults to version 11 #385

mstahv opened this issue Feb 14, 2024 · 4 comments
Labels
duplicate This issue or pull request already exists kind/bug Something isn't working

Comments

@mstahv
Copy link
mstahv commented Feb 14, 2024

"Nobody" uses that old Java these days, I'd expect there to be 21. Tryid to deploy my test throug Cloud Shell and it only allowed to choose between 17 & 21.

@jama22
Copy link
Collaborator
jama22 commented Feb 16, 2024

Ah, yeah linking this back to #254

Java 11 is hardcoded, which I really want to bump but that'd be a breaking change to most people. Our next opportunity is with google-24 builder coming later this year when we publish the Ubuntu 24 based builders. We really should just unpin the java buildpack and respect the language-idiomatic declarations

@jama22 jama22 added kind/bug Something isn't working duplicate This issue or pull request already exists labels Feb 16, 2024
@matthewrobertson
Copy link
Member

I don't think we need to wait for google-24 to make this change. All other runtimes default to the latest available version and parse framework configs / env vars for overrides. IIRC the reason we didn't do this for Java was because we were pulling the JDK from a public repo that didn't have a version index, but that is no longer an issue now that we are hosting our own JDK tarballs.

@tireiron
Copy link

This is making it hard to test gen 2 Cloud Functions, which only support Java 17 and 21.

@gdaramol
Copy link
gdaramol commented Jun 4, 2024

Is there a workaround for this? I thought setting GOOGLE_RUNTIME_VERSION to 17 would fix my issue as per the note in 254, but I've been unsuccessful.

Currently following these docs here when I ran into the issue: https://cloud.google.com/functions/docs/running/functions-emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants