[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug /Question/Request?] config.loglevel #243

Open
hmenzagh opened this issue Jun 8, 2020 · 3 comments
Open

[Bug /Question/Request?] config.loglevel #243

hmenzagh opened this issue Jun 8, 2020 · 3 comments

Comments

@hmenzagh
Copy link
Contributor
hmenzagh commented Jun 8, 2020

To keep it simple:

I'm trying to log what routes are called but not the result, and changing between :

 * - INTERNAL use it for logging calls and other internal stuff
 * - DEBUG recommended to use it for debugging applications
 * - NOTE development verbose information (default)
 * - INFO minor information
 * - LOG significant messages

does not seem to do much. Am I missing something ?
If I change the loglevel to WARNING nothing shows up (maybe errors etc) but not the routes being generated for instance.

Is that the expected behavior ?

(running the latest version of everything)
@JKHeadley
Copy link
Owner

@hmenzagh sorry for the delay. Yes I believe this is just a matter of better configuring of the logging code, which is in need of some pretty major refactoring in general. Most likely you are referring to the list results, which can be quite verbose:

https://github.com/JKHeadley/rest-hapi/blob/master/utilities/handler-helper.js#L221

I'll see about at least changing this to Log.info to help keep it manageable, or please feel free to do it yourself and open a PR :)

@hmenzagh
Copy link
Contributor Author

Thanks ! I'll look into it if you didn't do the changes next time I manage my rest-hapi code

@hmenzagh
Copy link
Contributor Author
hmenzagh commented Jul 16, 2020 •
edited
Loading

Pull request : #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JKHeadley @hmenzagh