[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve privacy model #30

Closed
calebbourg opened this issue Sep 20, 2022 · 1 comment · Fixed by #33
Closed

Improve privacy model #30

calebbourg opened this issue Sep 20, 2022 · 1 comment · Fixed by #33
Assignees
@jhodapp @calebbourg
Labels
enhancement Improves existing functionality or feature
Milestone
0.2 Release

Comments

@calebbourg
Copy link
Collaborator

There are a number publicly exposed types that should be private. Ex. Operation

see this comment

AC:

  • All types other than Wifi and potentially FirmwareVersion are private
@calebbourg calebbourg added the enhancement Improves existing functionality or feature label Sep 20, 2022
@calebbourg calebbourg self-assigned this Sep 20, 2022
@calebbourg calebbourg added this to the 0.2 Release milestone Sep 20, 2022
@calebbourg calebbourg mentioned this issue Sep 20, 2022
Merged
@jhodapp
Copy link
Member
jhodapp commented Sep 22, 2022

Rust documentation on how to accomplish this: https://doc.rust-lang.org/reference/visibility-and-privacy.html

@jhodapp jhodapp self-assigned this Oct 12, 2022
@jhodapp jhodapp mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhodapp jhodapp

@calebbourg calebbourg

Labels
enhancement Improves existing functionality or feature
Projects
ESP32-WROOM-RP
Status: Done
Milestone
0.2 Release
2 participants
@jhodapp @calebbourg