[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert get_connection_status() result to be an enum type #42

Closed
3 tasks done
jhodapp opened this issue Nov 8, 2022 · 0 comments · Fixed by #47
Closed
3 tasks done

Convert get_connection_status() result to be an enum type #42

jhodapp opened this issue Nov 8, 2022 · 0 comments · Fixed by #47
Assignees
@dilyn-corner
Labels
enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.3 Release

Comments

@jhodapp
Copy link
Member
jhodapp commented Nov 8, 2022 •
edited by dilyn-corner

Project Related Enhancement:

Currently, get_connection_status() returns the raw u8 integer value passed directly from the esp32 target up to the application using the crate. These should be converted and mapped to a new enum type.

Related issue: #40

Definition of Done:

  • Raw u8 values are no longer passed through to application layer
  • New enum type should be defined and u8 results mapped to this type
  • Existing example join in the cross directory should be updated to use new enum type
@jhodapp jhodapp added enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed labels Nov 8, 2022
@jhodapp jhodapp added this to the 0.3 Release milestone Nov 8, 2022
@dilyn-corner dilyn-corner mentioned this issue Nov 17, 2022
Merged
@jhodapp jhodapp mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilyn-corner dilyn-corner

Labels
enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
ESP32-WROOM-RP
Status: Done
Milestone
0.3 Release
Development

Successfully merging a pull request may close this issue.

Create and use a ConnectionStatus enum Jim-Hodapp-Coaching/esp32-wroom-rp
2 participants
@jhodapp @dilyn-corner