[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request / Suggestion]: clarify enum names ConnectionState vs ConnectionStatus #66

Open
dilyn-corner opened this issue Jan 13, 2023 · 0 comments
Labels
enhancement Improves existing functionality or feature

Comments

@dilyn-corner
Copy link
Contributor

Suggestion / Feature Request

Currently we have an enum named ConnectionState. We also have an enum named ConnectionStatus. While fine because both of the things they are used for are stateful in nature, they're a little close and could lead to confusion or pseudo-ambiguity.

We should check the names of our enums (and potentially other things) to see if we can make them more specific. For the above example, perhaps TcpState and WiFiState.

This doesn't block publishing but is a future thing to examine.

@dilyn-corner dilyn-corner added the enhancement Improves existing functionality or feature label Jan 13, 2023
@jhodapp jhodapp changed the title [Feature Request / Suggestion]: clarify enum names [Feature Request / Suggestion]: clarify enum names ConnectionState vs ConnectionStatus Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
None yet
Development

No branches or pull requests

1 participant