[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect polyline "closed" property editing via properties dialog #1774

Open
sand1024 opened this issue May 8, 2024 · 1 comment
Open
Labels
bug An error which causes unexpected or unintended results

Comments

@sand1024
Copy link
Contributor
sand1024 commented May 8, 2024

Polyline is not drawn as closed after editing of "closed" flag via properties dialog.

Expected behavior

if "closed" flag is set in properties dialog, after closing properties dialog polyline should be drawn as closed one

Observed behavior

polyline still is drawn as not closed as soon as properties dialog is closed.

After forced redraw via menu - no still not closed. Zooming, panning - no effect. Modifying vertexes of the polyline - no effect.

If file is saved and reopened - proper closed polyline is drawn.

It does not matter, whether flag is checked or unchecked - it seems that proper drawing of polyline occurs only on next loading of the document.

Steps to reproduce or sample file

  1. Select any polyline
  2. Modify value of "closed" property (switch of state is needed)
  3. Close the dialog

Operating System and LibreCAD version info

Version: 2.2.0
Compiler: GNU GCC 12.2.0
Compiled on: Dec 17 2022
Qt Version: 5.12.11
Boost Version: 1.75.0
System: Windows 10 (10.0)

Current development snapshot from master

@sand1024
Copy link
Contributor Author
sand1024 commented May 8, 2024

and a bit more details - the "closed" flag itself on RS_Polyline is properly set after editing. However, it seems that appropriate entity is not added/removed as part of RS_EntityContainer... I'll take closer look to this later, I suppose

@dxli dxli added the bug An error which causes unexpected or unintended results label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error which causes unexpected or unintended results
Projects
None yet
Development

No branches or pull requests

2 participants