Async command parsing in ImageSharp.Web #99
-
|
I have a use case where I need to set a default focal/anchor point (parameter Since most calls would complete synchronously, the API is returning ValueTask to avoid allocating a task when it's not needed. public interface SixLabors.ImageSharp.Web.Commands.IRequestParser
{
// existing API
// IDictionary<string, string> ParseRequestCommands(HttpContext context);
// new API
ValueTask<IDictionary<string, string>> ParseRequestCommandsAsync(HttpContext context);
}I've implemented it in https://github.com/wagich/ImageSharp.Web/tree/async-command-parsing |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 8 replies
-
|
Hi @wagich that sounds like something you would do via the OnParseCommands event. Do you have a single focal point reused across all images or one per image? |
Beta Was this translation helpful? Give feedback.
-
|
And maybe to give a bit more context: |
Beta Was this translation helpful? Give feedback.
-
|
Ok... That all makes sense. So it seems like converting the |
Beta Was this translation helpful? Give feedback.
-
|
It looks like it. I'll take some time today and change my code to use the |
Beta Was this translation helpful? Give feedback.
-
|
Excellent. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
It seems to be working using the callback. I've opened a draft pull request #100 with the changes. |
Beta Was this translation helpful? Give feedback.
Hi @wagich that sounds like something you would do via the OnParseCommands event.
Do you have a single focal point reused across all images or one per image?