[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Panel.fit forgot height and highlight parameters #3142

Closed
2 tasks done
xymy opened this issue Oct 5, 2023 · 3 comments · Fixed by #3192
Closed
2 tasks done

[BUG] Panel.fit forgot height and highlight parameters #3142

xymy opened this issue Oct 5, 2023 · 3 comments · Fixed by #3192
Labels
Needs triage

Comments

@xymy
Copy link
Contributor
xymy commented Oct 5, 2023

Describe the bug

Panel.fit forgot height and highlight parameters. It should be updated to synchronize with the constructor.

class Panel(JupyterMixin):
    def __init__(
        self,
        renderable: "RenderableType",
        box: Box = ROUNDED,
        *,
        title: Optional[TextType] = None,
        title_align: AlignMethod = "center",
        subtitle: Optional[TextType] = None,
        subtitle_align: AlignMethod = "center",
        safe_box: Optional[bool] = None,
        expand: bool = True,
        style: StyleType = "none",
        border_style: StyleType = "none",
        width: Optional[int] = None,
        height: Optional[int] = None,
        padding: PaddingDimensions = (0, 1),
        highlight: bool = False,
    ) -> None:
        ...

    @classmethod
    def fit(
        cls,
        renderable: "RenderableType",
        box: Box = ROUNDED,
        *,
        title: Optional[TextType] = None,
        title_align: AlignMethod = "center",
        subtitle: Optional[TextType] = None,
        subtitle_align: AlignMethod = "center",
        safe_box: Optional[bool] = None,
        style: StyleType = "none",
        border_style: StyleType = "none",
        width: Optional[int] = None,
        padding: PaddingDimensions = (0, 1),
    ) -> "Panel":
        ...
@github-actions
Copy link
github-actions bot commented Oct 5, 2023

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@darrenburns darrenburns mentioned this issue Nov 7, 2023
Merged
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 7, 2023

I hope we solved your problem.

If you like using Rich, you might also enjoy Textual

@darrenburns
Copy link
Member

Thanks for creating this issue. I've merged a fix for it which should be included in the next release, however I'm not sure when that'll be yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing Panel.fit parameters Textualize/rich
2 participants
@darrenburns @xymy