[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback #45

Open
rahulkuriyedath opened this issue Jan 30, 2021 · 1 comment
Open

Peer feedback #45

rahulkuriyedath opened this issue Jan 30, 2021 · 1 comment

Comments

@rahulkuriyedath
Copy link

Hi Group 12!

This is Rahul from group 11, please find below my feedback regarding the dashboard you created.

Things that I liked:-

  1. The overall dashboard is quite informative.
  2. The UI is easy to use and self-explanatory.

Thing that I felt could be improved:

  1. When I toggle between “Confirmed”,”Death” and “recovered” , the highlight seems to stay on the “confirmed” button even though the map changed, which confused me a little. I think this issue is there with all the tabs.

  2. The Total Cases and Recovered counts for individual countries is using scientific notation for large numbers (for example, when India is selected) which is a little difficult to read.

  3. Perhaps you could use different color schemes for ‘confirmed’ , ‘deaths’ and ‘recovered’ such as green for recovered, red for deaths and blue for confirmed.

Other than this, I think its a good dashboard. Please let me know if you need any clarifications regarding the above points. All the best!

@lephanthuymai
Copy link
Collaborator

Hi Rahul,
Thank you very much for your feedback, those make sense, we will try our best to implement those in Milestone #4.
Regarding point #1 in the improvement list: there is a square wrapped around the selected button, but I guess it might be too subtle to notice, we will try something else.
All the best,
Mai - on behalf of Group 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants