[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated Github Actions using node version 12 #14558

Open
ajahl opened this issue Nov 28, 2022 · 3 comments
Open

Outdated Github Actions using node version 12 #14558

ajahl opened this issue Nov 28, 2022 · 3 comments
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) good first issue Good for newcomers tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc

Comments

@ajahl
Copy link
Contributor
ajahl commented Nov 28, 2022 •
edited by mpfirrmann
Loading

Problem

Following Github changelog, all actions that use Node 12 need to be migrated to run on Node 16 by summer 2023. Several Github actions are already upgraded in #12209. However there are still a couple of actions (see action list) that could not be updated because the actions are not maintained and suitable replacements are not available or restrictions are not met. For example, the new version only supports Ubuntu runners, but MacOS runners are required.

Concerned Github Actions

Actions already report warnings: Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout
@ajahl ajahl added the type: proposal Proposals and design documents label Nov 28, 2022
@ajahl ajahl mentioned this issue Nov 28, 2022
Closed
4 tasks
@ajahl ajahl removed the type: proposal Proposals and design documents label Nov 28, 2022
@nstng nstng added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Dec 12, 2022
@LKreutzer LKreutzer mentioned this issue Feb 6, 2023
Open
@LKreutzer
Copy link
Contributor

tim-actions/get-pr-commits and tim-actions/dco have not had releases in over a year, it might make sense to replace them by more up-to-date actions.

Ilshidur/action-slack has not had a release since Sept. 2020 and we are already also using the rtCamp/action-slack-notify. It should be checked if there is a better action, else we could migrate all steps to use the rtCamp/action-slack-notify action.

@LKreutzer LKreutzer added tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc good first issue Good for newcomers labels Feb 10, 2023
@ajahl
Copy link
Contributor Author
ajahl commented Feb 10, 2023 •
edited
Loading

rtCamp/action-slack-notify is not usable in Mac runners due to the applied Docker container. That was the reason why the Ilshidur/action-slack action could not be replaced. By the way, rtCamp/action-slack-notify uses Go in version 1.12 inside the container.

@Zhenye-Na
Copy link
Zhenye-Na commented Oct 8, 2023 •
edited
Loading

I am interested in taking Ilshidur/action-slack action to its latest version. will work on this and send out a PR

Actually I double checked that the following 3 github actions are their latest. Is there still anything left for this issue ?

Ilshidur/action-slack
tim-actions/get-pr-commits
tim-actions/dco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) good first issue Good for newcomers tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajahl @Zhenye-Na @LKreutzer @nstng