[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using Maybe in /lib/hooks/useRequestState.ts #1

Open
Gnadhi opened this issue Mar 31, 2022 · 4 comments
Open

using Maybe in /lib/hooks/useRequestState.ts #1

Gnadhi opened this issue Mar 31, 2022 · 4 comments

Comments

@Gnadhi
Copy link
Gnadhi commented Mar 31, 2022 •
edited
Loading

Hi there Im just wondering where does the Maybe keyword come from in the file above this is not obvious to me. Why not just use ErrorType | undefined is there even a generic Maybe type in typescript if it comes from a package this should be made more obvious and be imported. Otherwise, thanks for the great starter template it helped me a lot :)
@Gbuomprisco
Copy link
Contributor

Hey @Gnadhi, some stuff was missing. I just updated the repository. 🤞

You can find the commit here aadc35a with also more improvements.

Let me know if you need further help :)

@Gnadhi
Copy link
Author
Gnadhi commented Apr 6, 2022

Great thanks for fixing that up

@Gnadhi
Copy link
Author
Gnadhi commented Apr 6, 2022

I would also note that I would recommend using the nextjs router in the guard auth component for speeder redirects and since you know in this case redirects should be internal URL it should be find to use

@Gbuomprisco
Copy link
Contributor

Hey @Gnadhi, thanks for the heads up!

Do you mean this particular line?

 window.location.assign(whenSignedOut);

If so, that's likely to prevent a known issue in reactfire when using a live firestore subscription: FirebaseExtended/reactfire#485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gbuomprisco @Gnadhi