[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for touch events to violent theremin demo #126

Open
chrisdavidmills opened this issue Jan 18, 2021 · 4 comments
Open

Add support for touch events to violent theremin demo #126

chrisdavidmills opened this issue Jan 18, 2021 · 4 comments

Comments

@chrisdavidmills
Copy link
Contributor
chrisdavidmills commented Jan 18, 2021 •
edited by Josh-Cena
Loading

@normanr commented on Wed Dec 02 2020

It would be nice to be able to use the demo in a touch environment (eg: phone or tablet). (Not required: sound could be continuous after a 'start/down' event until an 'end/up' event is received)

@chrisdavidmills commented on Wed Dec 02 2020

I agree that this would be nice.

For reference:

@normanr commented on Wed Dec 02 2020

(side-note: the event listeners for triggering init should be removed in init, otherwise using the keyboard causes init to be triggered multi times, and DOMExceptions when trying to remove the startMessage that has already been removed).
@chrisdavidmills chrisdavidmills mentioned this issue Jan 18, 2021
Closed
@chrisdavidmills chrisdavidmills added the effort: medium Task is a medium effort. label Jan 18, 2021
@Rumyra
Copy link
Contributor
Rumyra commented Feb 18, 2021

Would it be ok to take this on and give it a bit of a re-write (inc touch events) and also move it into the webaudio-examples repo @chrisdavidmills ?

@chrisdavidmills
Copy link
Contributor Author

@Rumyra yes, I'm fine with that. It is mentioned a few times on MDN, so make sure there is some kind of redirect in place.

@Rumyra
Copy link
Contributor
Rumyra commented Feb 18, 2021

Thank you! Yep I think I'm going to roll it into a bigger task of auditing audio, so I'm hoping that won't be too much of a problem 👍

@Rumyra Rumyra self-assigned this Feb 18, 2021
@teoli2003 teoli2003 reopened this May 29, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 29, 2022
@sideshowbarker sideshowbarker removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 30, 2022
@Josh-Cena Josh-Cena removed the effort: medium Task is a medium effort. label Jun 13, 2024
@wbamberg wbamberg transferred this issue from mdn/content Jun 19, 2024
@github-actions GitHub Actions
Copy link

It looks like this is your first issue. Welcome! 👋
One of the project maintainers will be with you as soon as possible. We
appreciate your patience. To safeguard the health of the project, please
take a moment to read our code of conduct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chrisdavidmills @sideshowbarker @Rumyra @teoli2003 @Josh-Cena