[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch on/off button not implemented #25

Closed
pjmartorell opened this issue Nov 17, 2018 · 6 comments · Fixed by #102
Closed

Switch on/off button not implemented #25

pjmartorell opened this issue Nov 17, 2018 · 6 comments · Fixed by #102
Labels
idle Issues and pull requests with no activity for three months.

Comments

@pjmartorell
Copy link

webaudio-examples/audio-basics/index.html

Line 33 in e7f0c80

<button class="control-power" role="switch" aria-checked="false" data-power="on">

@chrisdavidmills
Copy link
Contributor

This is true. @Rumyra , was this intentional? I don't think it is a big deal in any case.

@Rumyra
Copy link
Contributor
Rumyra commented Nov 28, 2018

Yes this was intentional I was pre-empting phase two of the boombox.

I can happily remove the button and re-implement for version 2 if it's a problem/confusing?

@chrisdavidmills
Copy link
Contributor

Yeah, I think commenting out for now would be good

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Dec 28, 2022
@rohini-ranjanR
Copy link
Contributor

Hi, @Rumyra If the issue is open can I temporarily delete it or comment button to contribute to it?
Thanks

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Feb 26, 2023
@Rumyra
Copy link
Contributor
Rumyra commented Mar 9, 2023

Hey @rohini-ranjanR yes that would be great - if you want to delete or comment out ping me and I'll review the pr 👍

@rohini-ranjanR rohini-ranjanR mentioned this issue Mar 9, 2023
Merged
@rohini-ranjanR
Copy link
Contributor

Thanks, @Rumyra here's my PR.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove on/off switch button
4 participants
@chrisdavidmills @Rumyra @pjmartorell @rohini-ranjanR