[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search is not excluding the folders in the "files excluded through settings" #15313

Closed
ramya-rao-a opened this issue Nov 10, 2016 · 6 comments
Closed

Search is not excluding the folders in the "files excluded through settings" #15313

ramya-rao-a opened this issue Nov 10, 2016 · 6 comments
Assignees
@chrmarti
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@ramya-rao-a
Copy link
Contributor

Smoke Testing 1.7.2

  • VSCode Version: 1.7.2
  • OS Version: Windows

Steps to Reproduce:

image
@rebornix
Copy link
Member

Not seeing this issue on macOS so likely Windows specific.

@roblourens
Copy link
Member

And not on Linux

@ramya-rao-a ramya-rao-a added the search Search widget and operation issues label Nov 10, 2016
@ramya-rao-a
Copy link
Contributor Author

Synced with @chrmarti

I had one of the files from the said node_modules folder open while doing this search, in which case the folder is expected to be included in the file search.

Without the file from node_modules folder open, search does exclude the folders correctly.

@chrmarti chrmarti assigned chrmarti and unassigned sandy081 Nov 10, 2016
@chrmarti chrmarti added this to the November 2016 milestone Nov 10, 2016
@bpasero
Copy link
Member
bpasero commented Dec 7, 2016

Is this #6904 ?

@roblourens
Copy link
Member

Yes, I think this is by-design basically

@chrmarti chrmarti removed this from the November 2016 milestone Dec 7, 2016
@chrmarti chrmarti added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 7, 2016
@chrmarti
Copy link
Contributor
chrmarti commented Dec 7, 2016

Closing as duplicate. Thanks.

@chrmarti chrmarti closed this as completed Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@roblourens @rebornix @bpasero @chrmarti @sandy081 @ramya-rao-a