[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding is confusing if it has two different cases of enablement #213738

Closed
connor4312 opened this issue May 28, 2024 · 2 comments
Closed

Keybinding is confusing if it has two different cases of enablement #213738

connor4312 opened this issue May 28, 2024 · 2 comments
Assignees
@meganrogge
Labels
info-needed Issue requires more information from poster

Comments

@connor4312
Copy link
Member

Testing #213343

This is telling me alt+k does two different things:

image

Maybe things that only apply to when the accessibility help view is open should say that to avoid conflicts
@meganrogge
Copy link
Contributor
meganrogge commented May 30, 2024 •
edited
Loading

@connor4312 we resolve the keybinding for the accessibility help view focused context, so isn't it clear that alt+k applies when in the help dialog? and doesn't the when clause in the keybindings editor suffice?

what are you suggesting we do here?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label May 30, 2024
@connor4312
Copy link
Member Author

Oh, I misread the help, I thought the two alt+k's were different keybindings. This is fine then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@connor4312 @meganrogge