[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLS: leave english strings in source code to avoid NLS bundle lookup #214568

Closed
bpasero opened this issue Jun 7, 2024 · 1 comment
Closed

NLS: leave english strings in source code to avoid NLS bundle lookup #214568

bpasero opened this issue Jun 7, 2024 · 1 comment
Assignees
@bpasero
Labels
perf-startup performance

Comments

@bpasero
Copy link
Member
bpasero commented Jun 7, 2024 •
edited
Loading

We should measure if simply leaving the english strings in the sources wouldn't be faster than having to load the english bundle on startup to get at the values.
@bpasero bpasero self-assigned this Jun 7, 2024
@bpasero
Copy link
Member Author
bpasero commented Jun 25, 2024

We will not do this.

@bpasero bpasero closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

Labels
perf-startup performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpasero