-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect black-scene change - From Cursor position #1226
Comments
would an alternative be to make the black scene change always append segments, instead of deleting existing segments? then you won't lose any existing segments when calling black scene |
Yes, that's a good idea too. However, with the current implementation segments are created for the black scenes, instead of the non-blacks (which should be the normal case). So, everytime after running the "detect"-functionality I have to click on "invert all segments". |
I've changed the black detect so that it searches only the interval defined by the currently selected segment |
That works fine, thanks a lot! However, as mentioned earlier, the "blacks" are segments instead of the scences with content. This results in having a mix of "content"-segments (e.g. manually created) and "black"-segments. It threfore would be much better if you could have the content scences being created as segments. |
I think you can now achieve your initial request of only detecting segments to the right of the cursor by doing this:
If that's not what you want, I'm not sure what you exactly mean by "content segments" vs "black segments". |
Your approach works fine for me. |
It's pretty cool how you implemented #623 ! And it works very well!
One small addendum I would have though: Would it be possible to have the "Detect black scenes" functionality working from cursor position onward?
Currently I have already created some segments they all are being deleted by Detect black scenes".
Starting the black scenes from cursor position onward would result in the following benefits:
a) It would take less time to process seeking for black scenes (e.g. if the cursor is in mid-file, only have the file would have to be processed)
b) The existing segments (left of cursor position that is) would remain existing.
The text was updated successfully, but these errors were encountered: