[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect black-scene change - From Cursor position #1226

Closed
adoenz opened this issue Jul 15, 2022 · 6 comments
Closed

Detect black-scene change - From Cursor position #1226

adoenz opened this issue Jul 15, 2022 · 6 comments

Comments

@adoenz
Copy link
adoenz commented Jul 15, 2022

It's pretty cool how you implemented #623 ! And it works very well!

One small addendum I would have though: Would it be possible to have the "Detect black scenes" functionality working from cursor position onward?
Currently I have already created some segments they all are being deleted by Detect black scenes".
Starting the black scenes from cursor position onward would result in the following benefits:
a) It would take less time to process seeking for black scenes (e.g. if the cursor is in mid-file, only have the file would have to be processed)
b) The existing segments (left of cursor position that is) would remain existing.

@mifi
Copy link
Owner
mifi commented Jul 16, 2022

would an alternative be to make the black scene change always append segments, instead of deleting existing segments? then you won't lose any existing segments when calling black scene

@adoenz
Copy link
Author
adoenz commented Aug 28, 2022

Yes, that's a good idea too. However, with the current implementation segments are created for the black scenes, instead of the non-blacks (which should be the normal case). So, everytime after running the "detect"-functionality I have to click on "invert all segments".
So, if you could by default create only segments for scenes with content then your solution for "from cursor position onward" would be perfect.

@mifi
Copy link
Owner
mifi commented Oct 14, 2022

I've changed the black detect so that it searches only the interval defined by the currently selected segment

@mifi mifi closed this as completed in 0803858 Oct 14, 2022
@adoenz
Copy link
Author
adoenz commented Oct 25, 2022

That works fine, thanks a lot!

However, as mentioned earlier, the "blacks" are segments instead of the scences with content. This results in having a mix of "content"-segments (e.g. manually created) and "black"-segments.

It threfore would be much better if you could have the content scences being created as segments.

@mifi
Copy link
Owner
mifi commented Oct 27, 2022

I think you can now achieve your initial request of only detecting segments to the right of the cursor by doing this:

  • Create a new segment starting from the cursor position and onwards towards the end of the video.
  • make sure this segment you just created is selected
  • Detect black scenes, now it will only detect to the right of the cursor (the current segment)
  • now you can delete the original segment you created

If that's not what you want, I'm not sure what you exactly mean by "content segments" vs "black segments".

@adoenz
Copy link
Author
adoenz commented Nov 1, 2022

Your approach works fine for me.
What I mean by "content segments" vs "black segments": Lossless currently creates segments for the blacks (instead of the scences with actual footage, i.e. "a dog running"); this requires me to always "invert segments" so that I have segments with actual content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants