[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Title tag readout to the Tracks Screen #1530

Closed
4 tasks done
DmitriyYukhanov opened this issue Mar 31, 2023 · 5 comments
Closed
4 tasks done

Add Title tag readout to the Tracks Screen #1530

DmitriyYukhanov opened this issue Mar 31, 2023 · 5 comments

Comments

@DmitriyYukhanov
Copy link

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Description

Hey @mifi

Could it be a good idea to add the 'title' column on the Tracks Screen? It would make it easier to distinguish tracks from each other when a video has many tracks with different translations for the same language, like this one:

image

Possibly should be discussed at #482, but creating a separate issue for now.

@mifi
Copy link
Owner
mifi commented Apr 3, 2023

Hi. Not sure what's a "title". Where does does it come from?

@DmitriyYukhanov
Copy link
Author
DmitriyYukhanov commented Apr 3, 2023

Hi @mifi I mean this one:
image

@mifi
Copy link
Owner
mifi commented Apr 3, 2023

Do you know any (small) example file that has this tag?

@DmitriyYukhanov
Copy link
Author

Actually, it wasn't easy to find something small with multiple audio tracks where the title would be filled on public since this is something I do usually see in bigger files with multiple dubs.

Still, I found the Pixar intro which has an audio track with the title tag filled, here is an under-15-megs cut of it:
Pixar-logo-cut.zip

I've also realized this can be something rarely filled and wouldn't worth it to always occupy space for this tag in Tracks Screen table as in most cases it can be empty.

Instead, it might be nice to show a title column on the Tracks Screen if at least 1 track has this tag filled.

Please let me know what do you think. While I'm not proficient with JS, I'd still be happy to participate and try crafting it in PR.

@mifi mifi closed this as completed in 0d3fe99 Apr 4, 2023
@DmitriyYukhanov
Copy link
Author

Amazing, thank you 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants