[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Introduce a local web server for tests #1808

Open
st3fan opened this issue May 14, 2021 · 1 comment
Open

Introduce a local web server for tests #1808

st3fan opened this issue May 14, 2021 · 1 comment
Labels
eng:ui-test UI tests
Projects
Focus iOS Test Eng Kanban

Comments

@st3fan
Copy link
Contributor
st3fan commented May 14, 2021 •
edited by data-sync-user
Loading

While removing the dependency on GCDWebServer with #1771 I noticed that some of the UI tests like to load http://localhost:6573/licenses.html - we cannot depend on that anymore so I replaced that with an external site. This works, but it is less reliable than a locally run webserver just for tests.

Let's start a minimal web server as part of the tests - this can ultimately replace all tests that load web pages.

┆Issue is synchronized with this Jira Task
This was referenced May 14, 2021
Closed
Merged
@st3fan st3fan added the eng:ui-test UI tests label May 19, 2021
@st3fan
Copy link
Contributor Author
st3fan commented May 19, 2021

I added the eng:ui-test label but I think this would be equally useful for the unit tests too. I'm not sure if we actually contact external sites from those, but if we do then we should replace those calls with a local webserver too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:ui-test UI tests
Projects
Focus iOS Test Eng Kanban
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st3fan