Add pipe uid and support more detailed log for read/write #414
Conversation
| @@ -201,4 +209,14 @@ impl PipeType for FileRef { | |||
| .downcast_ref::<PipeWriter>() | |||
| .ok_or_else(|| errno!(EBADF, "not a pipe writer")) | |||
| } | |||
|
|
|||
| fn channel_uid(&self) -> Result<usize> { | |||
| let pipe_end = self.as_pipe_reader(); | |||
There was a problem hiding this comment.
Is it possible to get the channel, then get the channel_uid from the channel?
| fn gen_uid(ring_buf: &RingBuffer<I>) -> usize { | ||
| use crate::util::random; | ||
| let mut random_buf: [u8; 8] = [0u8; 8]; // same length as usize | ||
| random::get_random(&mut random_buf).expect("failed to get random number"); |
There was a problem hiding this comment.
Random does not guarantee two channels would get different id.
It maybe a good enough implementation for debug purpose. Please add a TODO here, to replace it with a more consistent implementation.
There was a problem hiding this comment.
In case you are interested, there is an object_id crate in NGO for exact this purpose.
There was a problem hiding this comment.
@tatetian Thank you for this suggestion. However, besides the uniqueness of this uid, it would be better if the developer can find all the references with this ID, which can be very helpful when we need to find the pattern of this access. So the uid should contain many digits. Maybe we can make object_id start from a big random value and then atomically increase by 1 or a small random value?
Current read/write log can't provide enough info for complicated applications. This commits improve this situation
Regular file read and close:
Pipe file read and close:
Other file types could be added in the future.