[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomGremlinGroovyPipeline#getString throws an IllegalStateException when the pipeline contains more than one element #36

Open
gdaniel opened this issue Aug 16, 2017 · 1 comment
Open

CustomGremlinGroovyPipeline#getString throws an IllegalStateException when the pipeline contains more than one element #36

gdaniel opened this issue Aug 16, 2017 · 1 comment
Labels
bug Performance question

Comments

@gdaniel
Copy link
Contributor
gdaniel commented Aug 16, 2017

I am not sure this restriction is actually needed. A getString method on a pipeline containing multiple elements could return a generic String built by appending the elements one after the other.

We need to be clear on this method: is it only a debugging method that helps to understand what is in the pipeline, or is it also used in the translations (for example of toString() calls in ATL)? In the later we have to be careful, because String comparisons can have unexpected behaviors if we use a generic pattern for multiple elements.
@gdaniel
Copy link
Contributor Author
gdaniel commented Aug 16, 2017

This method could be removed and translated like the following traversal:

[...]_().next().toString()

However, this translation may have some impact on the performances (need some benchmarks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Performance question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdaniel