[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkout-multiple-repos-side-by-side doc example #1021

Closed
maxatka opened this issue Nov 23, 2022 · 2 comments · Fixed by #1050
Closed

checkout-multiple-repos-side-by-side doc example #1021

maxatka opened this issue Nov 23, 2022 · 2 comments · Fixed by #1050

Comments

@maxatka
Copy link
maxatka commented Nov 23, 2022 •
edited
Loading

The README.md contains example for mulitple checkouts in the context of one organization, if I'm not wrong.
May be, it's about to checkout public repository.

There is another example - checkout-multiple-repos-private, but is a repository of the same organization on GitHub for which the GitHub action is run, is considered "private" as well?

I thought if I run the action in private repository for my organization, other private repositories are accessible.
If not, it's better to precise the documentation by adding to "Checkout multiple repos (private)" something like:

...so if your want to checkout a different repository that is private (no matter if it's the same organization on GitHub or not)...

and to "Checkout multiple repos (side by side)" example to add something like:

Attention! You second repository must be public, even if it's from the same organization on GitHub that the action repository.
layjosh8 referenced this issue Nov 25, 2022
@jokreliable @jsoref
wrap pipeline commands for submoduleForeach in quotes (#964)
bf08527 
* wrap pipeline commands for submoduleForeach in quotes

* Update src/git-auth-helper.ts

drop extraneous space.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* Followed CONTRIBUTING.md instructions, updating dist/index.js

* fixed package-lock.json

* updating the pipeline so it runs from sh

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@vanZeben vanZeben mentioned this issue Dec 16, 2022
Merged
@vanZeben
Copy link
Contributor
vanZeben commented Dec 16, 2022 •
edited
Loading

Hey @maxatka, thank you for the feedback!

The Private keyword directly corresponds to the visibility of the repository in the settings.

To directly answer your question is a repository of the same organization on GitHub for which the GitHub action is run, is considered "private" as well?. That solely uses the visibility settings I mentioned above to determine whether or not the repo is private. .

We note in a few places that we use ${{ github.token }} by default which is scoped to the current repository only. This means that it only has permission to access the current repository within an organization and you will need to include a PAT token for it to access other private repositories.

I've added in a PR to add a reference to the private section just to make it more clear :)

@maxatka
Copy link
Author
maxatka commented Dec 17, 2022

@vanZeben Thanks for your feedback!
Appreciate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in explicit reference to private checkout options actions/checkout
2 participants
@vanZeben @maxatka