[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with location #161

Closed
JFGHT opened this issue May 25, 2023 · 5 comments · Fixed by #162
Closed

Problem with location #161

JFGHT opened this issue May 25, 2023 · 5 comments · Fixed by #162

Comments

@JFGHT
Copy link
JFGHT commented May 25, 2023 •
edited
Loading

I recently installed this extension. It seems it works correct for the first task but after that, it's selecting the incorrect location (default us-central1).

My guess it's because of this line: https://github.com/algolia/firestore-algolia-search/blob/main/functions/src/index.ts#L203

Which should be:

locations/${process.env.LOCATION}/functions/ext-firestore-algolia-search-executeFullIndexOperation,

But I have not tested it.

PS: also when reinstalling the extension there's a problem at creating the queue with the same name because GC takes up to 7 days to remove it.
@JFGHT JFGHT mentioned this issue May 25, 2023
Closed
@smomin
Copy link
Collaborator
smomin commented May 25, 2023

I am working with the Firebase team on the location issue. As for GC taking longer than 7 days, thats should be something the Firebase should help on. I can ask but it would be good to open a ticket with them on this issue.

@JFGHT
Copy link
Author
JFGHT commented May 25, 2023

I am working with the Firebase team on the location issue. As for GC taking longer than 7 days, thats should be something the Firebase should help on. I can ask but it would be good to open a ticket with them on this issue.

You could ask and we could also check how to create the queue with a dynamic name (timestamped or something).

@smomin smomin linked a pull request May 25, 2023 that will close this issue
Fix queue function ref #162
Merged
@smomin
Copy link
Collaborator
smomin commented May 25, 2023

@JFGHT I have created a RC https://console.firebase.google.com/project/_/extensions/install?ref=algolia/firestore-algolia-search@1.1.1-rc.0. Use this RC version while the final build is going through the Firebase Approval process.

@JFGHT
Copy link
Author
JFGHT commented May 26, 2023 •
edited
Loading

Thanks @smomin, glad I could help.

Any info regarding the 7 days restriction? Because this actually blocks me reinstalling the extension via firebase console.

And btw, could you lead me to any docs of how to install RCs or other versions of an extension?

@smomin
Copy link
Collaborator
smomin commented May 26, 2023

hey @JFGHT the extension stable build is now approved so you can install this version through the extension marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix queue function ref algolia/firestore-algolia-search
2 participants
@smomin @JFGHT