[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why Github Sample not updated to use hilt, coroutines and flow #966

Open
burhankhanzada opened this issue Feb 17, 2021 · 4 comments
Open

Why Github Sample not updated to use hilt, coroutines and flow #966

burhankhanzada opened this issue Feb 17, 2021 · 4 comments

Comments

@burhankhanzada
Copy link

I want to follow best practices for modern android develop and GitHub sample is a complete solution for that but there soe much old code and like using dagger 2 why its not updating to use hilt and koltin continues and flow for background work instead of executors
@burhankhanzada burhankhanzada changed the title Why Github Smaple not updated to use hil insted of dagger 2 Why Github Smaple not updated to use hilt, coroutines and flow Feb 17, 2021
@burhankhanzada burhankhanzada changed the title Why Github Smaple not updated to use hilt, coroutines and flow Why Github Sample not updated to use hilt, coroutines and flow Feb 17, 2021
@sdfgsdfgd
Copy link

this is so true, especially with private val viewModel: ExampleViewModel by hiltNavGraphViewModels(R.id.navgraphid) hilt nav graph parameter VM injections, I'd love to see this in sample and also an example of global actions between different nav graphs using these.

@DJDrama
Copy link
DJDrama commented Apr 22, 2021

Well because hilt is beta ??

@TheSomeshKumar
Copy link

Well because hilt is beta ??

Well, It isn't anymore

@DJDrama
Copy link
DJDrama commented May 12, 2021

Well because hilt is beta ??

Well, It isn't anymore

it was beta when this question was written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DJDrama @TheSomeshKumar @sdfgsdfgd @burhankhanzada and others