Integrate FLP as a Location source #220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Jan 23, 2024
| @@ -168,6 +192,9 @@ class ExerciseClientManager @Inject constructor( | |||
| * cancelled, this flow will unregister the listener. | |||
| * [callbackFlow] is used to bridge between a callback-based API and Kotlin flows. | |||
| */ | |||
| @OptIn(ExperimentalCoroutinesApi::class) | |||
| @SuppressLint("MissingPermission") | |||
There was a problem hiding this comment.
Worrying to have suppressions. Are there ways to structure without needing a suppression?
yschimke
reviewed
Jan 23, 2024
| requestLocationUpdates(locationRequest, locationListener, Looper.getMainLooper()) // is this the right looper? | ||
| awaitClose { removeLocationUpdates(locationListener) } | ||
|
|
||
| Log.d("qqqqqq", "requested location updates") |
There was a problem hiding this comment.
this won't display, awaitClose{} is blocking. move above?
yschimke
reviewed
Jan 23, 2024
|
|
||
| override fun onExerciseUpdateReceived(update: ExerciseUpdate) { | ||
|
|
||
| val hasLocation = update.latestMetrics.getData(DataType.LOCATION).isNotEmpty() |
There was a problem hiding this comment.
Probably worth some comments why you are working around WHS. Or is this something health-services-client should be doing?
yschimke
reviewed
Jan 23, 2024
|
|
||
| @SuppressLint("RestrictedApi") | ||
| @Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE") | ||
| fun DataPointContainer.fromLocation(l: Location) { |
There was a problem hiding this comment.
This feels awkward, ideally would only be in test code.
If you want to leave it, it should have a TODO linking to a tracking bug requesting these APIs be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO