You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I add comments to my SQL tables and columns, I would love to see a little tooltip in the SQL Lab sidebar that shows those comments.
It looks like maybe we used to do this - here's an ancient PR.
However, now there are no tooltips!
The table_metadata API still does return the column & table comments:
However they don't appear to be actually used in the TableMetadata or Column types.
My questions are:
is this a regression/bug that should be fixed? If so, I'm happy to give it a shot - let me know about any conventions/components/dev environment/testing stuff that I should look at before I start. I would probably post some sort of rough plan of attack before getting too deep into the weeds to make sure I'm going in the right direction.
is this a feature request? If so, does that require further discussion/decision making around whether or not to do this?
it seems like the external_metadata_by_name endpoint that the dataset "sync columns from source" button hits also returns column comments, which don't go anywhere... should that be a separate feature request?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi!
When I add comments to my SQL tables and columns, I would love to see a little tooltip in the SQL Lab sidebar that shows those comments.
It looks like maybe we used to do this - here's an ancient PR.
However, now there are no tooltips!
The
table_metadata
API still does return the column & table comments:However they don't appear to be actually used in the
TableMetadata
orColumn
types.My questions are:
external_metadata_by_name
endpoint that the dataset "sync columns from source" button hits also returns column comments, which don't go anywhere... should that be a separate feature request?Beta Was this translation helpful? Give feedback.
All reactions