[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Unfix numpy dependency #2664

Closed
TobyRoseman opened this issue Nov 18, 2019 · 3 comments · Fixed by #2996
Closed

Unfix numpy dependency #2664

TobyRoseman opened this issue Nov 18, 2019 · 3 comments · Fixed by #2996
Assignees
@TobyRoseman
Labels
p3 setup
Milestone
6.2

Comments

@TobyRoseman
Copy link
Collaborator

Currently in our setup.py we fix our numpy dependency: numpy==1.16.4.

This is likely to cause dependency conflicts in our users' environments. Instead we should fix a minimum version. However we should be aware that the dependency range that coremltools specifies is not accurate.
@TobyRoseman TobyRoseman mentioned this issue Nov 18, 2019
Closed
@TobyRoseman TobyRoseman added this to the 6.1 milestone Dec 10, 2019
@TobyRoseman TobyRoseman self-assigned this Dec 10, 2019
@TobyRoseman TobyRoseman added the p3 label Dec 13, 2019
@srikris
Copy link
Contributor
srikris commented Jan 16, 2020

@TobyRoseman What's left to be done on this?

@TobyRoseman
Copy link
Collaborator Author

@TobyRoseman What's left to be done on this?

The coremltools python package needs to do a release with my fix. Then turicreate needs to depend on that new version and unfix the numpy dependency.

@TobyRoseman
Copy link
Collaborator Author

The 3.2 release of coremltools does not fix the underlying issue. Removing from the current milestone.

@TobyRoseman TobyRoseman modified the milestones: 6.1, 6.2 Jan 28, 2020
@TobyRoseman TobyRoseman mentioned this issue Feb 8, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TobyRoseman TobyRoseman

Labels
p3 setup
Projects
None yet
Milestone
6.2
Development

Successfully merging a pull request may close this issue.

Upgrade coremltools version. Unfix numpy version. TobyRoseman/turicreate
2 participants
@srikris @TobyRoseman