[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Error comparing recommender models #2758

Closed
subodhchhabra opened this issue Dec 2, 2019 · 5 comments · Fixed by #3080
Closed

Error comparing recommender models #2758

subodhchhabra opened this issue Dec 2, 2019 · 5 comments · Fixed by #3080
Assignees
@TobyRoseman
Labels
bug recommender toolkits
Milestone
6.2

Comments

@subodhchhabra
Copy link

while calling tc.recommender.util.compare_models(tst, models=[m1, m2, m3]), statement errors with following error ..

TypeError Traceback (most recent call last)
in
----> 1 tc.recommender.util.compare_models(tst, models=[m1, m2, m3], verbose=False)

~/anaconda3/envs/turi/lib/python3.7/site-packages/turicreate/toolkits/recommender/util.py in compare_models(dataset, models, model_names, user_sample, metric, target, exclude_known_for_precision_recall, make_plot, verbose, **kwargs)
323 verbose=verbose,
324 cutoffs=list(range(1,11,1))+list(range(11,50,5)),
--> 325 **kwargs)
326 results.append(r)
327

TypeError: evaluate() got an unexpected keyword argument 'verbose'
@syoutsey
Copy link
Collaborator
syoutsey commented Dec 2, 2019

Hi @subodhchhabra, what version of Turi Create are you running? How about operating system?

@subodhchhabra
Copy link
Author

mac OS 10.14.6,
TuriCreate - 5.8

@TobyRoseman
Copy link
Collaborator

After looking at the relevant code, I'm guessing at least one of the models isn't a recommender.

@subodhchhabra - what types of models are m1, m2, and m3?

@subodhchhabra
Copy link
Author

yes, I did miss that , so I guess we need to check of model type is a recommender.

@TobyRoseman
Copy link
Collaborator
TobyRoseman commented Dec 3, 2019 •
edited
Loading

yes, I did miss that , so I guess we need to check of model type is a recommender.

Agreed. turicreate.recommender.util.compare_models should make sure all of the models passed in are sub classes of turicreate.toolkits.recommender.util._Recommender.

@TobyRoseman TobyRoseman added this to the 6.2 milestone Jan 31, 2020
@TobyRoseman TobyRoseman self-assigned this Mar 31, 2020
@TobyRoseman TobyRoseman mentioned this issue Mar 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TobyRoseman TobyRoseman

Labels
bug recommender toolkits
Projects
None yet
Milestone
6.2
Development

Successfully merging a pull request may close this issue.

Basic parameter checking in tc.recommender.util.compare_models TobyRoseman/turicreate
3 participants
@syoutsey @subodhchhabra @TobyRoseman