[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does this line of code mess with the ordering in MD plots? #5

Open
DanielRPhillips opened this issue Feb 6, 2024 · 1 comment
Open

Does this line of code mess with the ordering in MD plots? #5

DanielRPhillips opened this issue Feb 6, 2024 · 1 comment
Assignees
@jordan-melendez

Comments

@DanielRPhillips
Copy link
Contributor

Brad McClung has been generating the gsum diagnostics for the order-by-order coefficients in Wolfenstein amplitudes. He had some odd results with MD^2s not being consistent with the PC decomposition. We think we found that this line of code was switching around the sequence of the orders in the MD^2 plots, causing them to be mislabeled and miscolored.

gsum/gsum/diagnostics.py

Line 447 in 05d81ec

positions = positions[inv]

@DanielRPhillips
Copy link
Contributor Author

Maybe the most useful thing is to explain to us what this line of code is meant to do and why we shouldn't just take the ordering of the points that comes from seaborn's swarmplot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordan-melendez jordan-melendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordan-melendez @DanielRPhillips