-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move coverage to GitHub actions #10898
Move coverage to GitHub actions #10898
Conversation
IS_PUBLISH=true make build-standalone | ||
# data for a JS file that's several megabytes large is bound to fail. Here, | ||
# we just run the babel-standalone test separately. | ||
yarn jest "\-standalone/test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is just for coverage, maybe we can avoid testing standalone here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standalone is only tested on the coverage job in the CI, we have skipped the test on other executors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh then maybe we should test it separately? I don't really see how it fits in the coverage tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but standalone will rely on building and installing all the dependencies, I think we can test it here to save redundant machine hours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fair
a6b4865
to
6b47be7
Compare
ENOMEM: not enough memory, stat /home/circleci/babel/packages/just/click/the/rerun/button
This PR moves the coverage report job to GitHub Actions. The ENOMEM error should be alleviated because
Merge tips:
Please add
CODECOV_TOKEN
to theSettings > Secrets
after merging to master. See https://github.com/codecov/codecov-action#usage