[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

php7.4 compatible code release branch #265

Closed
kishoresai438 opened this issue Nov 18, 2020 · 1 comment · Fixed by #270
Closed

php7.4 compatible code release branch #265

kishoresai438 opened this issue Nov 18, 2020 · 1 comment · Fixed by #270

Comments

@kishoresai438
Copy link
kishoresai438 commented Nov 18, 2020 •
edited
Loading

Hi Team,

I saw that there is one commit to fix PHP7.4 compatible curly braces issue. Code is in dev-master(https://github.com/census-instrumentation/opencensus-php/pull/258/files), but not in any release branch. Can we expect this in release branch?

I am using Stack driver exporter lib, but they are not supporting dev-master. So please provide release branch for that. So that they can update stackdriver exporter lib. Thanks.
https://packagist.org/packages/opencensus/opencensus-exporter-stackdriver
@boris-hocde
Copy link
boris-hocde commented Nov 25, 2020 •
edited
Loading

@kishoresai438 As quick fix, you can temporarily disable E_DEPRECATED reporting when starting the tracer:

$initialErrorReporting = error_reporting();
error_reporting($initialErrorReporting ^ E_DEPRECATED);

Tracer::start($exporter, [
    'sampler' => $sampler,
]);

error_reporting($initialErrorReporting);

@MrMage MrMage mentioned this issue May 26, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with PHP 8 Timing-GmbH/opencensus-php
2 participants
@boris-hocde @kishoresai438