[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-TTY use cases #131

Open
slp opened this issue Mar 31, 2023 · 2 comments
Open

Support non-TTY use cases #131

slp opened this issue Mar 31, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@slp
Copy link
Contributor
slp commented Mar 31, 2023

In its current form, the way in which stdin/stdout are tied to virtio-console only plays nice with interactive TTY-like sessions. This means, in may scenarios, libkrun-based VMMs can't be used from scripts.

We need to revamp the way in which stdin/stdout, virtio-console and init.c interact between them to also support non-TTY use cases. This means we need to:

  • Stop tying the VM lifetime to the availability of stdin.
  • Implement a handshake between virtio-console and init.c to ensure no bytes are lost while the VM is booting.
  • Extend init.c so, when a non-TTY use case is detected, is kept alive acting as proxy between the app running in the VM and virtio-console.

This will fix #130 #97

@slp slp added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Mar 31, 2023
@jakecorrenti
Copy link
Member
jakecorrenti commented Aug 2, 2024

I would like to give this a try

@slp
Copy link
Contributor Author
slp commented Aug 5, 2024

@jakecorrenti This should be mostly covered by #157, but it'd be nice confirming we aren't missing anything to cover this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants